Adding System.Threading.Channels for simplified, better performing code.#835
Merged
lukebakken merged 2 commits intorabbitmq:masterfrom May 20, 2020
Merged
Adding System.Threading.Channels for simplified, better performing code.#835lukebakken merged 2 commits intorabbitmq:masterfrom
lukebakken merged 2 commits intorabbitmq:masterfrom
Conversation
11 tasks
1063ee6 to
4aceebe
Compare
lukebakken
requested changes
May 19, 2020
projects/RabbitMQ.Client/client/events/AsyncEventingBasicConsumer.cs
Outdated
Show resolved
Hide resolved
lukebakken
approved these changes
May 20, 2020
Collaborator
|
Thanks! |
This was referenced Jul 29, 2025
This was referenced Aug 5, 2025
This was referenced Aug 17, 2025
This was referenced Sep 15, 2025
This was referenced Oct 20, 2025
This was referenced Nov 24, 2025
This was referenced Dec 2, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This adds System.Threading.Channels for a much more optimized and easy to use construct for asynchronous consumer/producer queue (like used in the Async Dispatcher and the Recovery queue). After looking at optimizations and code surrounding the AsyncConcurrentQueue this seems like a much more sane approach.
This adds a new dependency on the System.Threading.Channels NuGet package (supported by all platforms).
Types of Changes
Checklist
CONTRIBUTING.mddocumentFurther Comments
This package has been used in previous PRs (f.ex. #824) and also the PRs that were part of the bigger Pipelines and allocation PRs, but this stands very well on it's own and is perfectly compatible with both 7.0.0 and 6.X. and is a simple change.