Move BinaryTableValue to public section#880
Merged
lukebakken merged 1 commit intorabbitmq:masterfrom Jun 24, 2020
Merged
Conversation
|
@BenBorn Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@BenBorn Thank you for signing the Contributor License Agreement! |
michaelklishin
changed the title
michaelklishin
requested changes
Jun 24, 2020
Contributor
michaelklishin
left a comment
michaelklishin
left a comment
There was a problem hiding this comment.
RabbitMQ.Client.client.api is not a namespace used by this client. I don't see any updates to API approval tests either. This needs more work.
Collaborator
|
@michaelklishin I'll wrap this one up this morning. |
Move BinaryTableValue to apiApproval section
lukebakken
force-pushed
the
feature/879-binarytablevalue
branch
from
4d152a9 to
87bb569
Compare
Collaborator
|
@BenBorn thanks! |
lukebakken
added a commit
that referenced
this pull request
Jun 24, 2020
Move BinaryTableValue to public section (cherry picked from commit f088565)
This was referenced Jul 29, 2025
This was referenced Aug 5, 2025
This was referenced Aug 17, 2025
This was referenced Sep 15, 2025
This was referenced Oct 20, 2025
This was referenced Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#879
Proposed Changes
Move the BinaryTableValue class to the public section, because its returned by:
'result.BasicProperties.Headers.TryGetValue("key", out object value);'
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply