7.0: update target framework from net461 to netcoreapp3.1#971
7.0: update target framework from net461 to netcoreapp3.1#971michaelklishin merged 1 commit intorabbitmq:masterfrom
Conversation
| <PackageOutputPath>..\..\packages</PackageOutputPath> | ||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | ||
| <CodeAnalysisRuleSet>RabbitMQ.ruleset</CodeAnalysisRuleSet> | ||
| <LangVersion>latest</LangVersion> |
There was a problem hiding this comment.
I would not set the language version to latest. Because that allows you to use language features that might not be supported by the TFMs chosen here. If you leave it blank you get automatically the proper language version supported by the TFM intersection
https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/configure-language-version
There was a problem hiding this comment.
Doesn't "The compiler accepts syntax from the latest released version of the compiler" mean it will always choose the latest possible whatever framework version we selected?
There was a problem hiding this comment.
No, it will choose the the latest version the compiler knows about, overriding the version that would have been picked by the compiler based on the TFM.
@danielmarbach is right that it should not be set to get the automatic behavior that we want here.
There was a problem hiding this comment.
Well that's wrong then, sorry. I'll update it in one of my next PRs. Thanks for the review
|
@bollhals I failed to backport this to |
Proposed Changes
7.0 Change
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
CONTRIBUTING.mddocument