Ensure that peer node deals with unicode#10826
Merged
Merged
Conversation
lukebakken
force-pushed
the
peer-disc-temporary-nodes-and-inetrc
branch
from
March 22, 2024 16:12
41d3c68 to
3fd96a0
Compare
lukebakken
force-pushed
the
peer-discovery-utf8-settings
branch
from
March 22, 2024 16:13
2c38a00 to
d885abe
Compare
michaelklishin
force-pushed
the
peer-disc-temporary-nodes-and-inetrc
branch
from
March 25, 2024 19:19
3fd96a0 to
1bcfa47
Compare
lukebakken
force-pushed
the
peer-discovery-utf8-settings
branch
from
October 27, 2025 14:36
d885abe to
5ec1824
Compare
Follow-up to #10759 Related to #10194 Related to erlang/otp#8289
lukebakken
force-pushed
the
peer-discovery-utf8-settings
branch
from
February 23, 2026 16:24
5ec1824 to
151f3aa
Compare
lukebakken
added a commit
to rabbitmq/rabbitmq-website
that referenced
this pull request
Feb 23, 2026
The Erlang preprocessor interprets files as Latin-1 by default. Without the `%% coding: utf-8` directive, non-ASCII characters in values such as the `password` field are not parsed correctly. Add the directive and an explanatory comment to both the Linux and Windows `inter_node_tls.config` example blocks. Related to erlang/otp#8289 Related to rabbitmq/rabbitmq-server#10826
`application:get_env(kernel, inetrc)` can return an atom when the user specifies the filename without Erlang-style quoting. The existing call to `unicode:characters_to_list/1` crashes with `badarg` on atoms. Add a function head that converts atoms to lists before falling through to the clause that handles unicode conversion. Follow-up to #10826
lukebakken
marked this pull request as ready for review
February 23, 2026 16:43
dumbbell
approved these changes
Feb 23, 2026
dumbbell
left a comment
dumbbell
left a comment
Collaborator
There was a problem hiding this comment.
This looks good to me, thanks!
michaelklishin
approved these changes
Feb 23, 2026
Collaborator
Author
|
Thanks! Better late than never! I may be the only person to have ever noticed this 😸 |
michaelklishin
pushed a commit
that referenced
this pull request
Feb 24, 2026
`application:get_env(kernel, inetrc)` can return an atom when the user specifies the filename without Erlang-style quoting. The existing call to `unicode:characters_to_list/1` crashes with `badarg` on atoms. Add a function head that converts atoms to lists before falling through to the clause that handles unicode conversion. Follow-up to #10826
michaelklishin
pushed a commit
that referenced
this pull request
Feb 24, 2026
`application:get_env(kernel, inetrc)` can return an atom when the user specifies the filename without Erlang-style quoting. The existing call to `unicode:characters_to_list/1` crashes with `badarg` on atoms. Add a function head that converts atoms to lists before falling through to the clause that handles unicode conversion. Follow-up to #10826
michaelklishin
pushed a commit
that referenced
this pull request
Feb 24, 2026
`application:get_env(kernel, inetrc)` can return an atom when the user specifies the filename without Erlang-style quoting. The existing call to `unicode:characters_to_list/1` crashes with `badarg` on atoms. Add a function head that converts atoms to lists before falling through to the clause that handles unicode conversion. Follow-up to #10826
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10759
Related to #10194
Related to erlang/otp#8289