Skip to content

Very minor: Remove outdated comment from rabbit_msg_store (backport #14190) #14258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 21, 2025

Proposed Changes

Sorry for providing a PR instead of asking the question: Is that correct that "The value close is never stored in the file handle ets since commit 32816c0."?

I found this comment while investigating #14181. As far as I can see the value can never be close so it cannot be the cause of the bug.

During the same investigation I got another question. Comment says (https://github.com/rabbitmq/rabbitmq-server/blob/v4.1.2/deps/rabbit/src/rabbit_msg_store.erl#L520-L522)

Get index for all Msgids in File.
It's possible that we get no results here if compaction
was in progress. That's OK: we will try again with those
MsgIds to get them from the new file.

But compaction (as opposed to combination) doesn't create new files. Only moves messages within the same file. How can a message be moved to a "new file" (assuming it has positive refcount)?

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

Further Comments


This is an automatic backport of pull request #14190 done by [Mergify](https://mergify.com).

The value `close` is never stored in the file handle ets since commit 32816c0.

(cherry picked from commit 6ccfe6a)
@michaelklishin michaelklishin added this to the 4.1.3 milestone Jul 21, 2025
@michaelklishin michaelklishin merged commit 59ecfe4 into v4.1.x Jul 21, 2025
274 checks passed
@michaelklishin michaelklishin deleted the mergify/bp/v4.1.x/pr-14190 branch July 21, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants