By @LoisSotoLopez: reconcile quorum queue member list after queue deletion and (re)declaration#15615
Merged
Conversation
Co-authored-by: Péter Gömöri <gomoripeti@users.noreply.github.com>
I thought that asserting the right membership status on all nodes would guarantee that the other status fields would be the expected ones but it seems like that assumption was wrong.
- Only query node uids via RPC for missing members - Update nodes in state to map if FF is enabled - Properly return whether queue repaired or not Co-authored-by: Péter Gömöri <gomoripeti@users.noreply.github.com>
- data dir should only be deleted if RaUid is not undefined (and it does not match the UID in metadata store) - does not need to log separately if RaUid is undefined as that is already logged when restart_server returns with name_not_registered error
This migration is very subtle. Let's make it 4.3.0-only.
…firms the value can be used
This new extracted function is pure and is an excellent candidate for property-based testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is #14241 by @LoisSotoLopez re-submitted by me with a few tweaks before merging:
4.3.0by making the new feature flag depend onrabbitmq_4.3.0caseclauses in question has lost a catch-all change which means that an error returned byra:start_server/2would result in afunction_clausefailureThe key ideas in the original PR are still intact.