Shovels: refactor in follow-up to #14256#16676
Merged
Merged
Conversation
As of #14256 (shipped in `4.2.0`), AMQP 1.0 shovels stop modifying properties and simply pass them along. This means we can drop the `properties` translation part entirely, avoiding a completely useless conversion. While at it, do not try to convert unknown protocol names, fall back to AMQP 0-9-1 instead of storing an aribtrary protocol name.
michaelklishin
added a commit
that referenced
this pull request
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of #14256 (shipped in
4.2.0), AMQP 1.0 shovels stop modifying properties and simply pass an immutable message along.This means we can drop the
propertiestranslation part entirely, avoiding a completely useless conversion.While at it, do not try to convert unknown protocol names, fall back to AMQP 0-9-1 instead of storing an aribtrary protocol name.