Skip to content

Encrypt http basic credentials#16705

Open
MarcialRosales wants to merge 6 commits into
mainfrom
encrypted-http-basic-credentials
Open

Encrypt http basic credentials#16705
MarcialRosales wants to merge 6 commits into
mainfrom
encrypted-http-basic-credentials

Conversation

@MarcialRosales

@MarcialRosales MarcialRosales commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

Implement feature requests:

docs pr: rabbitmq/rabbitmq-website#2543

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

@MarcialRosales MarcialRosales self-assigned this Jun 17, 2026
@MarcialRosales
MarcialRosales force-pushed the encrypted-http-basic-credentials branch 2 times, most recently from 08bdc69 to e864b3c Compare June 19, 2026 08:48
@MarcialRosales
MarcialRosales force-pushed the encrypted-http-basic-credentials branch 2 times, most recently from ae87f2d to 5d8945e Compare July 14, 2026 07:29
@MarcialRosales MarcialRosales changed the title Encrypted http basic credentials Encrypt http basic credentials Jul 14, 2026
@MarcialRosales
MarcialRosales marked this pull request as ready for review July 14, 2026 07:30
@mergify

mergify Bot commented Jul 14, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Comment thread deps/rabbitmq_management/priv/schema/rabbitmq_management.schema Outdated
Comment thread deps/rabbitmq_management/priv/schema/rabbitmq_management.schema

@michaelklishin michaelklishin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has the same regression we have fixed recently:
for OAuth 2-enabled deployments, oauth_completeLogin calls set_token_auth in a way that seemingly hardcodes the 8 hour timeout.

selenium/test/basic-auth/rabbitmq.encrypted-credentials.conf:1
still has management.credentials_encryption_secret ("credentials" in plural) vs. the rename singular Cuttlefish schema key.
This part I will correct myself since it's clear what should be done.

@MarcialRosales
MarcialRosales force-pushed the encrypted-http-basic-credentials branch from 2a18fac to 7e7b0bc Compare July 24, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants