Encrypt http basic credentials#16705
Open
MarcialRosales wants to merge 6 commits into
Open
Conversation
MarcialRosales
force-pushed
the
encrypted-http-basic-credentials
branch
2 times, most recently
from
June 19, 2026 08:48
08bdc69 to
e864b3c
Compare
MarcialRosales
force-pushed
the
encrypted-http-basic-credentials
branch
2 times, most recently
from
July 14, 2026 07:29
ae87f2d to
5d8945e
Compare
MarcialRosales
marked this pull request as ready for review
July 14, 2026 07:30
|
Tick the box to add this pull request to the merge queue (same as
|
michaelklishin
requested changes
Jul 15, 2026
michaelklishin
requested changes
Jul 20, 2026
michaelklishin
left a comment
Collaborator
There was a problem hiding this comment.
This PR has the same regression we have fixed recently:
for OAuth 2-enabled deployments, oauth_completeLogin calls set_token_auth in a way that seemingly hardcodes the 8 hour timeout.
selenium/test/basic-auth/rabbitmq.encrypted-credentials.conf:1
still has management.credentials_encryption_secret ("credentials" in plural) vs. the rename singular Cuttlefish schema key.
This part I will correct myself since it's clear what should be done.
MarcialRosales
force-pushed
the
encrypted-http-basic-credentials
branch
from
July 24, 2026 07:16
2a18fac to
7e7b0bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Implement feature requests:
docs pr: rabbitmq/rabbitmq-website#2543
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply