Skip to content

Refactor HTTP API responses#16709

Merged
michaelklishin merged 12 commits into
mainfrom
address-v-sec-issues
Jun 19, 2026
Merged

Refactor HTTP API responses#16709
michaelklishin merged 12 commits into
mainfrom
address-v-sec-issues

Conversation

@MarcialRosales

@MarcialRosales MarcialRosales commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

Favor 404 over 401 when user has no permission to a vhost
Support float as token expiry data type not only integer
Enforce is same user or admin/monitor when checking for user-limits for a specific user.
In rabbitmq_top plugin, validate sort parameters against a fix set of values

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

@MarcialRosales MarcialRosales self-assigned this Jun 17, 2026
@michaelklishin michaelklishin changed the title Address v sec issues Refactor HTTP API responses Jun 17, 2026
@MarcialRosales
MarcialRosales marked this pull request as ready for review June 18, 2026 06:28
@MarcialRosales
MarcialRosales requested a review from lhoguin June 18, 2026 10:21

@lhoguin lhoguin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve all except the super stream change as I don't have a full picture there.

@lhoguin

lhoguin commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Arnaud approved the super stream change but there are conflicts to solve now.

@mergify

mergify Bot commented Jun 19, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@michaelklishin michaelklishin added this to the 4.4.0 milestone Jun 19, 2026
@michaelklishin
michaelklishin merged commit 8bd3118 into main Jun 19, 2026
189 checks passed
@michaelklishin
michaelklishin deleted the address-v-sec-issues branch June 19, 2026 21:18
michaelklishin added a commit that referenced this pull request Jun 19, 2026
michaelklishin added a commit that referenced this pull request Jun 20, 2026
Refactor HTTP API responses (backport #16709) (backport #16742)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants