QQ: handle aux state upgrades from aux v1.#16990
Merged
Merged
Conversation
If this isn't done and a system is upgraded as: 3.13 -> 4.2 -> 4.3
then the aux state will initialise as aux v1 which the current version
of rabbit_fifo.erl does not handle. The aux state will never be
upgraded and thus the queue(s) will never emit metrics or take
snapshots.
kjnilsson
force-pushed
the
qq-aux-upgrade-fix-2
branch
from
July 21, 2026 13:23
f192c27 to
99c968a
Compare
the-mikedavis
approved these changes
Jul 21, 2026
Collaborator
|
I think we could catch this in a regression test too that sets initial_machine_version 0 and walks through the machine versions and then casts a tick aux command and does something to assert that the aux effects are working. |
kjnilsson
marked this pull request as ready for review
July 21, 2026 15:28
|
Tick the box to add this pull request to the merge queue (same as
|
It mimics existing tests for v1 => v2 and v2 => v3.
Collaborator
|
I have added a tiny aux_v3 => aux_v4 migration test that is virtually identical to two existing suites for v1 => v2 and v2 => v3 migrations. |
michaelklishin
added a commit
that referenced
this pull request
Jul 22, 2026
QQ: handle aux state upgrades from aux v1. (backport #16990)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this isn't done and a system is upgraded as: 3.13 -> 4.2 -> 4.3
then the aux state will initialise as aux v1 which the current version
of rabbit_fifo.erl does not handle. The aux state will never be
upgraded and thus the queue(s) will never emit metrics or take
snapshots.
Fixes #16974