Import definitions in the post-launch phase #2396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way definitions that depend on a plugin, such as federation upstreams or exchanges of custom types, can be imported successfully. Closes #2384
…d on boot This is a behavior we use to provide because definitions were imported before the empty DB boot step. Now when the definitions are imported in the post-launch phase, we'd always end up with default data seeded in addition to definitions being imported. References #2384
michaelklishin
added a commit
that referenced
this pull request
Jun 26, 2020
Import definitions in the post-launch phase (cherry picked from commit f935cc1)
|
Backported to |
lukebakken
added a commit
that referenced
this pull request
Mar 22, 2023
Fixes #7678 References: * #2384 * #2396 PR #2396 preserved the old behavior where definitions import took priority over the default data and environment data that may be present. This behavior continues to confuse users where they expect `RABBITMQ_DEFAULT_USER` / `RABBITMQ_DEFAULT_PASS` to be imported, especially if there is no `users` data in the definitions file. This PR allows default data and the environment to be imported first, then possibly overwritten by the definitions file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make sure definitions that depend on plugins (federation upstreams, shovels, exchanges of custom types) can be imported.
This preserves an implicit feature of the previous implementation: since definition import was performed in a boot step
that preceded the empty DB check one in the boot step DAG, a node with a definition file to load would not seed its default data (virtual host and user).
Closes #2384.