Allow use of long or short names via a variable in rabbitmq-env #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is sometimes useful to run the node with the long name, leave the default as -sname but allow using long name via a variable
It is sometimes useful to run the node with the long name, leave the default as -sname but allow using long name via a variable
ghost
|
This was fixed on the branch |
binarin
pushed a commit
that referenced
this pull request
Sep 28, 2021
…dary Umbrella Before, we were relying on the `secondary_erlang_mk_depsdir` config key value to compute the secondary path of an application. When there is no secondary Umbrella configured, the computed value was based on the primary `deps` dir. However, when the caller asks for the currently tested app, we might not be in an Umbrella at all: it's perfectly fine to e.g. clone the application alone and test it. In this case, the computed value would point to a non-existing directory (e.g. rabbitmq-server/deps/rabbit). So instead of relying on the default secondary Umbrella when there is none configured, we directly check if there is one configured. If there is none, the secondary path for the application is set to the primary path. This way, we are sure the directory exists and is correct, no matter how the project was cloned. Fixes #24.
dcorbacho
pushed a commit
that referenced
this pull request
Jul 5, 2023
Offset readers handle missing segments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple change to make it possible running with long names when needed