Skip to content

Fix close consumer #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Fix close consumer #113

merged 2 commits into from
Apr 29, 2022

Conversation

Gsantomaggio
Copy link
Member

When the consumer is removed from the server for some reason the call Unsubscribe could fail.
This fix avoids to wait too much time in case the server doesn't respond.

Signed-off-by: Gabriele Santomaggio [email protected]

When the consumer is removed from the server for some reason the call Unsubscribe could fail.
This fix avoids to wait too much time in case the server doesn't respond.

Signed-off-by: Gabriele Santomaggio <[email protected]>
When the consumer is removed from the server for some reason the call Unsubscribe could fail.
This fix avoids to wait too much time in case the server doesn't respond.

Signed-off-by: Gabriele Santomaggio <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #113 (7174eea) into main (8413897) will increase coverage by 0.08%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   91.67%   91.75%   +0.08%     
==========================================
  Files          72       72              
  Lines        5264     5279      +15     
  Branches      315      317       +2     
==========================================
+ Hits         4826     4844      +18     
+ Misses        369      367       -2     
+ Partials       69       68       -1     
Impacted Files Coverage Δ
RabbitMQ.Stream.Client/Consumer.cs 89.18% <71.42%> (-2.82%) ⬇️
RabbitMQ.Stream.Client/Client.cs 91.21% <100.00%> (+0.36%) ⬆️
Tests/SystemTests.cs 100.00% <100.00%> (ø)
...abbitMQ.Stream.Client/Reliable/ReliableProducer.cs 90.81% <0.00%> (+3.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8413897...7174eea. Read the comment docs.

@Gsantomaggio Gsantomaggio merged commit 4966c3e into main Apr 29, 2022
@Gsantomaggio Gsantomaggio deleted the fix_close_consumer branch April 29, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants