Skip to content

Get version via reflection #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2022
Merged

Conversation

lukebakken
Copy link
Contributor

This removes a build step that would result in a modified file every time.

The version shown is what MinVer sets as the "ProductVersion" assembly attribute. It's also what you see when you right-click on the .dll

Screenshot 2022-05-11 203819

@lukebakken lukebakken added this to the v1.0.0-beta.6 milestone May 12, 2022
@lukebakken lukebakken requested a review from Gsantomaggio May 12, 2022 03:41
@lukebakken lukebakken self-assigned this May 12, 2022
This removes a build step that would result in a modified file every time.
@lukebakken lukebakken force-pushed the lukebakken/version-via-reflection branch from 2cae10a to 377577d Compare May 12, 2022 03:44
@codecov-commenter
Copy link

Codecov Report

Merging #119 (377577d) into main (604f321) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   91.70%   91.65%   -0.05%     
==========================================
  Files          72       72              
  Lines        5290     5295       +5     
  Branches      332      332              
==========================================
+ Hits         4851     4853       +2     
+ Misses        361      360       -1     
- Partials       78       82       +4     
Impacted Files Coverage Δ
RabbitMQ.Stream.Client/Version.cs 100.00% <100.00%> (ø)
RabbitMQ.Stream.Client/LogEventSource.cs 90.69% <0.00%> (-2.33%) ⬇️
Tests/ClientTests.cs 95.94% <0.00%> (-1.36%) ⬇️
RabbitMQ.Stream.Client/Consumer.cs 88.28% <0.00%> (-0.91%) ⬇️
RabbitMQ.Stream.Client/Client.cs 92.35% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 604f321...377577d. Read the comment docs.

@Gsantomaggio
Copy link
Member

much better!

@Gsantomaggio Gsantomaggio merged commit 4571ba1 into main May 12, 2022
@Gsantomaggio Gsantomaggio deleted the lukebakken/version-via-reflection branch May 12, 2022 07:01
@lukebakken lukebakken modified the milestones: v1.0.0-beta.6, v1.0.0-rc.1 May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants