Handle infinite looping when encountering a misconfigured load balancer #121
Conversation
|
Thank you for your PR. I left a comment |
|
Submitted changes. Tried running unit tests with your approach ( |
|
Can you please execute |
|
Sorry for multiple commits, can only do this PR via github web UI. |
|
@ricsiLT don't worry :)! We will Squash the commits! |
|
In order to format you need to use the last version: they changed something, so previous versions won't work. if you can't update |
Signed-off-by: Gabriele Santomaggio <[email protected]>
|
So you'll merge this whenever? Nothing else required from me? |
I formatted the code. I will merge! Thank you |
The same for producer and consumer. Just to be sure to try all the nodes at least tree times to avoid temp fails Signed-off-by: Gabriele Santomaggio <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #121 +/- ##
==========================================
- Coverage 91.58% 91.57% -0.01%
==========================================
Files 72 72
Lines 5301 5331 +30
Branches 332 332
==========================================
+ Hits 4855 4882 +27
- Misses 365 370 +5
+ Partials 81 79 -2
Continue to review full report at Codecov.
|
Proposal to handle infinite looping when connecting to a load balancer where nodes are misconfigured, causing client to hang indefinitely.
Logic can be replaced by time-based loop, separate exception could be used if necessary (maybe even exposing nodes that were tried for easier diagnostics).