Refactor Confirmation Pipe and HeartBeat start #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move the confirmation pipe after the Producer initialization to avoid pendig thread in case the producer init fails * Move the heartbeat start after the login to avoid pending threads in case the client fails to connect for some reason. Signed-off-by: Gabriele Santomaggio <[email protected]>
lukebakken
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small improvements. In some cases, some threads could remain pending.
Move the confirmation pipe after the Producer initialization to avoid
pending thread in case the producer init fails
Move the heartbeat start after the login to avoid pending threads
in case the client fails to connect for some reason.
Signed-off-by: Gabriele Santomaggio [email protected]