Skip to content

Fix style in select classes to be more dotnet-like #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

ricardSiliuk
Copy link
Contributor

Misc fixes related to style.
Basically prefixing private variables in select classes with _.

@codecov
Copy link

codecov bot commented Jul 31, 2022

Codecov Report

Base: 92.70% // Head: 92.88% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (966d235) compared to base (b91ab49).
Patch coverage: 87.93% of modified lines in pull request are covered.

❗ Current head 966d235 differs from pull request most recent head aba4ca6. Consider uploading reports for the commit aba4ca6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   92.70%   92.88%   +0.17%     
==========================================
  Files          94       94              
  Lines        7839     7840       +1     
  Branches      592      592              
==========================================
+ Hits         7267     7282      +15     
+ Misses        457      446      -11     
+ Partials      115      112       -3     
Impacted Files Coverage Δ
RabbitMQ.Stream.Client/RawProducer.cs 82.79% <79.59%> (+1.86%) ⬆️
RabbitMQ.Stream.Client/RawConsumer.cs 89.24% <90.62%> (+2.53%) ⬆️
RabbitMQ.Stream.Client/StreamSystem.cs 86.58% <96.96%> (-0.06%) ⬇️
...bitMQ.Stream.Client/Reliable/IReconnectStrategy.cs 80.95% <100.00%> (+2.00%) ⬆️
RabbitMQ.Stream.Client/Client.cs 92.04% <0.00%> (+0.72%) ⬆️
RabbitMQ.Stream.Client/Reliable/ReliableBase.cs 96.29% <0.00%> (+1.23%) ⬆️
RabbitMQ.Stream.Client/Connection.cs 89.16% <0.00%> (+1.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'm pretty sure there's a setting in .editorconfig that could enforce this. I don't know what it is off the top of my head, however.

@lukebakken lukebakken self-assigned this Aug 3, 2022
@lukebakken lukebakken added this to the 1.0.0-rc.5 milestone Aug 3, 2022
@lukebakken lukebakken modified the milestones: 1.0.0-rc.5, 1.0.0-rc.6 Sep 6, 2022
@lukebakken lukebakken modified the milestones: 1.0.0-rc.6, 1.0.0-rc.7 Nov 7, 2022
@lukebakken
Copy link
Contributor

I'll continue work on this PR since I should be able to push to your fork @ricardSiliuk. I need to reconcile the .editorconfig settings we use in this project with those in the .NET AMQP client.

@lukebakken lukebakken force-pushed the misc/ricsi/fix-style-p1 branch from 506c948 to aba4ca6 Compare November 7, 2022 17:42
@lukebakken lukebakken merged commit a46d953 into rabbitmq:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants