Skip to content

Change definition of MaxLengthBytes stream specification - #165 #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

PaoloLaurenti
Copy link
Contributor

@PaoloLaurenti PaoloLaurenti commented Sep 21, 2022

Change definition of MaxLengthBytes stream specification from int to ulong.
I used unsigned type because negative values don't make sense for this setting.

Fixes: #165

@Gsantomaggio Gsantomaggio self-assigned this Sep 21, 2022
@Gsantomaggio Gsantomaggio added this to the 1.0.0-rc.6 milestone Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 91.87% // Head: 91.96% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (5612043) compared to base (36fa175).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   91.87%   91.96%   +0.08%     
==========================================
  Files          78       78              
  Lines        6201     6220      +19     
  Branches      385      385              
==========================================
+ Hits         5697     5720      +23     
+ Misses        410      408       -2     
+ Partials       94       92       -2     
Impacted Files Coverage Δ
RabbitMQ.Stream.Client/StreamSpec.cs 100.00% <100.00%> (ø)
Tests/StreamSpecTests.cs 100.00% <100.00%> (ø)
Tests/SystemTests.cs 100.00% <100.00%> (ø)
RabbitMQ.Stream.Client/WireFormatting.cs 70.50% <0.00%> (-4.32%) ⬇️
RabbitMQ.Stream.Client/Client.cs 90.81% <0.00%> (+0.78%) ⬆️
RabbitMQ.Stream.Client/Reliable/ReliableBase.cs 100.00% <0.00%> (+1.36%) ⬆️
RabbitMQ.Stream.Client/Connection.cs 89.16% <0.00%> (+1.66%) ⬆️
RabbitMQ.Stream.Client/Consumer.cs 91.89% <0.00%> (+3.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Gsantomaggio Gsantomaggio merged commit 4779c4d into rabbitmq:main Sep 21, 2022
@Gsantomaggio
Copy link
Member

Thanks @PaoloLaurenti

@PaoloLaurenti PaoloLaurenti deleted the change-max-length-definition branch September 21, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Max len from Int to in64
2 participants