Skip to content

Re-export Edition #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Re-export Edition #1000

merged 1 commit into from
Nov 16, 2018

Conversation

nrc
Copy link
Contributor

@nrc nrc commented Nov 16, 2018

Currently ProjectModelProvider cannot be implemented because there is no way to name Edition.

Currently `ProjectModelProvider` cannot be implemented because there is no way to name `Edition`.
@nrc nrc requested a review from kngwyu November 16, 2018 02:53
@kngwyu
Copy link
Collaborator

kngwyu commented Nov 16, 2018

Thanks, I forgot to modify rls side

@kngwyu kngwyu merged commit b4f94b4 into master Nov 16, 2018
@kngwyu kngwyu deleted the nrc-patch-1 branch November 16, 2018 04:47
Copy link
Collaborator

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Xanewok added a commit to rust-lang/rls that referenced this pull request Nov 16, 2018
For now this pulls Racer from git to include the
racer-rust/racer#1000.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants