Skip to content

Dataset Publishing Notebook ready for internal review #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

KennSmithDS
Copy link

@HamedAlemo the notebook for publishing to MLHub is read for review. The code should all work, the only question is in the last step where the archived .tar.gz file is saved to might be different when running the docker compose file locally vs on PlanetaryComputer. Will have to test to see if the outcomes are different:

  • /home/jovyan/tutorials (I believe this is how the docker image unpacks the contents)
  • home/jovyan/PlanetaryComputerExamples/tutorials (this is likely what it looks like on PC)

Otherwise, @pieschker advised that the Submit to Radiant ML Hub section at the end of the notebook could use a little more TLC, e.g. screenshots of what the browser view looks like, and actions taken to download the .tar.gz from the Notebook Server, and then how to click through the TypeForm.

@HamedAlemo
Copy link
Collaborator

@KennSmithDS this looks good.
Given that this version is going to be on PC's repo, I would say focus on PlanetaryComputer for instructions and file path.

I made some minor revisions to the description for MLHub submission part, replaced the folder path with /home/jovyan/PlanetaryComputerExamples/tutorials (cell 47), and corrected some typos throughout the notebook.

I don't think you need screenshots of the form, it should be self explanatory. But up to you and @pieschker .

@KennSmithDS
Copy link
Author

@HamedAlemo with your revisions, do you believe this is ready to merge or should we have another pair of eyes on it first?

@HamedAlemo
Copy link
Collaborator

Yup, good to go. Approving the merge request.

@HamedAlemo HamedAlemo merged commit e4e52f4 into radiantearth:add/dataset-publishing-tutorial Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants