Skip to content

Conversation

@philvarner
Copy link
Collaborator

Related Issue(s): #113

Proposed Changes:

  1. add ToC to all pages
  2. add text about how Item Search is limited and most behavior will be defined in extensions

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@cholmes
Copy link
Collaborator

cholmes commented May 11, 2021

Looks like this is made to master, not dev? I think with beta.1 release we now have dev vs master for API? It looks like there's more changes in this than I would expect.

@philvarner philvarner changed the base branch from master to dev May 11, 2021 18:01
@philvarner
Copy link
Collaborator Author

Looks like this is made to master, not dev? I think with beta.1 release we now have dev vs master for API? It looks like there's more changes in this than I would expect.

I did a few in a row, so of course I messed up this one. Fixed, now against dev.

@cholmes
Copy link
Collaborator

cholmes commented May 11, 2021

Cool. That's a much more reasonable number of files to review :)

@philvarner philvarner merged commit 83ba8f5 into radiantearth:dev May 12, 2021
@philvarner philvarner deleted the readme-item-search-reorg branch May 12, 2021 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants