Skip to content

Conversation

@philvarner
Copy link
Collaborator

Related Issue(s): #134

Proposed Changes:

  1. Add Collections conformance class defintion

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • This PR does not make any changes to the core spec in the stac-spec directory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@philvarner philvarner requested review from cholmes and m-mohr July 21, 2021 23:19
@philvarner philvarner mentioned this pull request Jul 21, 2021
4 tasks

## Link Relations

The following Link relations should exist in the Landing Page (root).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intended to have Link relations for the Landing page here on the Collections endpoint?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. We probably also need to clarify which link relations should exist on the /collections and /collections/{collectionid} endpoints for both this and ogcapi-features.

],
}
],
"links": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So no other links required: root, parent?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll improve this example.

@matthewhanson
Copy link
Collaborator

This seems fine, but wondering what is it that isn't captured in the existing http://www.opengis.net/spec/ogcapi-features-1/1.0/conf/core conformance class for the /collections endpoint that requires a STAC specific Collections conformance class?

@m-mohr
Copy link
Collaborator

m-mohr commented Aug 2, 2021

This seems fine, but wondering what is it that isn't captured in the existing http://www.opengis.net/spec/ogcapi-features-1/1.0/conf/core conformance class for the /collections endpoint that requires a STAC specific Collections conformance class?

It indicates that the collections are STAC compliant...

@m-mohr
Copy link
Collaborator

m-mohr commented Aug 3, 2021

Interesting PR, would like to review it as it's what we pioneered in the openEO API, but will likely take me some days to go through it.

@philvarner
Copy link
Collaborator Author

@matthewhanson This was Chris's idea, and it's basically to allow a user to advertise STAC-compliant Collections without needing to implement all of OGC API Features, e.g., they only want to implement Collections and Item Search. Ideally, there would be a way to define this without duplicating it from OAFeat, but this is what we have for now.

@philvarner philvarner merged commit 5e41c30 into radiantearth:dev Aug 6, 2021
@philvarner philvarner deleted the collections-cc branch August 6, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants