Shall and endpoint table #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…implemented for each conformance class
cholmes
approved these changes
Sep 7, 2021
Collaborator
cholmes
left a comment
cholmes
left a comment
There was a problem hiding this comment.
Looks good. Do we define somewhere our use of should / shall? Like refer to a document or explain it somewhere?
Collaborator
Author
|
We don't have it explicitly stated anywhere, but I think it's widely known enough that we don't need to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…implemented for each conformance class
Related Issue(s): #195
Proposed Changes:
Technically this is a breaking change, but it was understood before that these were required, we just used the wrong word in the spec.
PR Checklist:
stac-specdirectory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)