Skip to content

Conversation

@cholmes
Copy link
Collaborator

@cholmes cholmes commented Dec 4, 2020

Related Issue(s): #

Proposed Changes:

  1. Added language to make it clearer how to indicate POST can be used.

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • OpenAPI files only: I have run npm run generate-all to update the generated OpenAPI files.

@cholmes cholmes requested a review from m-mohr December 4, 2020 19:41
@cholmes
Copy link
Collaborator Author

cholmes commented Dec 4, 2020

@m-mohr - I hadn't realized you put the method thing in until after I submitted #77 I like the approach (hadn't really understood it). But I wasn't sure if you were supposed to add two links or one. My guess is two, so did that here, and tried for a little more clarity on required vs not. If I have it wrong let me know and I can try again.

Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the one requested change good to be merged.

removed stray 'either'
@m-mohr m-mohr merged commit d8bd349 into master Dec 4, 2020
@m-mohr m-mohr deleted the item-search-post branch December 4, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants