-
Notifications
You must be signed in to change notification settings - Fork 187
Add Portuguese (Brazil) locale [pt-BR] #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.github/CODEOWNERS
Outdated
| src/locales/it @p1d1d1 | ||
| src/locales/it-CH @p1d1d1 | ||
| src/locales/ro @mneagul | ||
| src/locales/pt-BR @uba |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've sent you an invite for this repository. Otherwise the codeowners file won't recognize you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invitation accepted!
README.md
Outdated
| - it: Italian (Italy, Switzerland) | ||
| - ro: Romanian | ||
| - ja: Japanese | ||
| - pt-BR: Portuguese (Brazil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whenever we have a new language, we start exposing it as language without the country specific code.
I'd propose to rename all this from pt-BR to pt and then split it up into pt-BR and pt-PT once someone comes up and suggest specific changes per country. Would you be fine with that? This would also allow Portuguese speakers from other countries than Brazil to automatically see a Portuguese translation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @m-mohr. Thanks for the review. I'm fine with that! No problem, let's rename it to "pt".
m-mohr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this, I highly appreciate all the work!
I left a couple of comments and we have two other to dos to onboard this:
- Potential rename from pt-BR to pt
- Add you to the GitHub repo. I've sent an invite.
- Add you to CrowdIn, which is our translation tool. Could you register at https://crowdin.com/project/stac-browser and let me know your name so that I can add you?
|
Thanks a lot! Sent an invite for CrowdIn. |
|
Thank you @m-mohr. CrowdIn invite accepted! |
This PR includes translations into Brazilian Portuguese (pt-BR). 📖