Skip to content

Conversation

@uba
Copy link
Collaborator

@uba uba commented Apr 29, 2024

This PR includes translations into Brazilian Portuguese (pt-BR). 📖

@uba uba requested a review from m-mohr as a code owner April 29, 2024 14:44
src/locales/it @p1d1d1
src/locales/it-CH @p1d1d1
src/locales/ro @mneagul
src/locales/pt-BR @uba
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've sent you an invite for this repository. Otherwise the codeowners file won't recognize you.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invitation accepted!

README.md Outdated
- it: Italian (Italy, Switzerland)
- ro: Romanian
- ja: Japanese
- pt-BR: Portuguese (Brazil)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever we have a new language, we start exposing it as language without the country specific code.
I'd propose to rename all this from pt-BR to pt and then split it up into pt-BR and pt-PT once someone comes up and suggest specific changes per country. Would you be fine with that? This would also allow Portuguese speakers from other countries than Brazil to automatically see a Portuguese translation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @m-mohr. Thanks for the review. I'm fine with that! No problem, let's rename it to "pt".

Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, I highly appreciate all the work!

I left a couple of comments and we have two other to dos to onboard this:

  1. Potential rename from pt-BR to pt
  2. Add you to the GitHub repo. I've sent an invite.
  3. Add you to CrowdIn, which is our translation tool. Could you register at https://crowdin.com/project/stac-browser and let me know your name so that I can add you?

@uba
Copy link
Collaborator Author

uba commented Apr 29, 2024

Hi @m-mohr

  1. pt-BR folder was renamed to pt and the related files adjusted
  2. Invitation accepted for this repostitory
  3. On CrowdIn, my username is the same as on GitHub - @uba.

Thank you!

@m-mohr m-mohr merged commit e222b97 into radiantearth:main Apr 29, 2024
@m-mohr
Copy link
Collaborator

m-mohr commented Apr 29, 2024

Thanks a lot! Sent an invite for CrowdIn.

@uba
Copy link
Collaborator Author

uba commented Apr 30, 2024

Thank you @m-mohr. CrowdIn invite accepted!

@uba uba deleted the add-pt-br branch April 30, 2024 15:16
silvester-pari pushed a commit to EOEPCA/open-science-catalog-stac-browser that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants