-
Notifications
You must be signed in to change notification settings - Fork 187
Add new option 'maxItemsPerPage' #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
So that's the maximum number a user can enter What's the usecase behind this? Did users enter 10000000 and the server returned an error? Do you want to configure a higher number than the old default? Usually pagination is in place and it shouldn't really matter. Also, Vue will probably not be able to render too high numbers if pagination is not active. |
|
It's the opposite, I would like to be able to specify a much lower limit (around 100) items for one of our STAC applications that acts as a proxy to another non-stac (OData) system where paginating over 10000 items would be very slow. We will enforce this limit server-side, but it would be great to make it also appear explicitly in the UI, so that users know how many items they can fetch at most in a single search query. The other idea that crossed my mind was to advertise this value in the
|
|
Seems reasonable. I'll merge. STAC historically doesn't use OpenAPI to adverstise server capabilities. It's in the spec as we inherited it from OGC APIs, but no client that I'm aware of makes use of it. |
This PR adds a new option in config.js:
which allows to define a custom value for the maximum number of items in the search filter: