Skip to content

Conversation

@KaseyW31
Copy link
Contributor

@KaseyW31 KaseyW31 commented Jun 6, 2025

This is a possible solution for independent item and collection search as mentioned in issue 599 for NASA ESDIS (I am one of the interns that Doug Newman mentioned). We believe the main issue we were facing boils down to how the search button link for a catalog page is generated.

Initially, search functionality for our ALL provider was not supported when accessing the search page from the provider page in CMR STAC. We found that directly accessing the search page correctly allows for independent collection search (even with the item search conformance classes, but we do intend to remove them).

The issue was that the search button link on the catalog page was falling back to the root catalog search. searchLink was set to null because the rel=search links for item search were removed in CMR STAC. Adding || this.data.getApiCollectionsLink() provides the correct search link when only collection search is supported (taking inspiration from lines 130-135 in src/views/Search.vue).

Please let me know if we have any misconceptions, and any feedback would be appreciated!

@KaseyW31 KaseyW31 requested a review from m-mohr as a code owner June 6, 2025 18:24
Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to think through potential side effects that may appear for other APIs. I think it looks good and I couldn't think of any side effects, but was this tested on other configurations than NASAs API? e.g. FedEO, other stac-fastapi-deployments, etc? It would be good to at least verify on some other API configurations that the behaviour doesn't change for the worse. Could you confirm, please? Thanks.

@m-mohr m-mohr added this to the 3.3.4 milestone Jun 9, 2025
@m-mohr m-mohr linked an issue Jun 9, 2025 that may be closed by this pull request
@m-mohr m-mohr added the search label Jun 9, 2025
@KaseyW31
Copy link
Contributor Author

KaseyW31 commented Jun 9, 2025

When testing several APIs, we didn't see changed behavior for search buttons/functionality. We looked at some in the STAC Browser index (including FedEO, GEP, UVT, Microsoft Planetary Computer, Terradue, as well as APIs without search) and some other stac-fastapi deployments (MAAP public API and catalog). Do you think there any others that should be tested on, or anything else to be checked in particular? Thanks!

@m-mohr
Copy link
Collaborator

m-mohr commented Jun 9, 2025

No, thanks for confirming.

@m-mohr m-mohr merged commit 7e3df34 into radiantearth:main Jun 9, 2025
@doug-newman-nasa
Copy link

Awesome work guys. @m-mohr thanks for your help. More coming from these guys in the next 8 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow for independent support of collection and item search

3 participants