Clarified that trailing slashes in URIs are significant. #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-mohr
force-pushed
the
trailing-slashes
branch
from
eeac4c6 to
e8c4095
Compare
cholmes
approved these changes
Jan 30, 2023
emmanuelmathot
approved these changes
Jan 30, 2023
Collaborator
emmanuelmathot
left a comment
emmanuelmathot
left a comment
There was a problem hiding this comment.
Great to clarify this! LGTM.
This was referenced Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): #1212
Proposed Changes:
PR Checklist:
or a CHANGELOG entry is not required.
and I have opened issue/PR #XXX to track the change.