This repository was archived by the owner on Feb 28, 2021. It is now read-only.
Properly isolate and document core state entities #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 3, 2020 11:11
We add the `radicle_registry_core::state` module and move all definitions of state entities there and include extensive documentation. We change the reference to all state entities to be qualified with `state`. We add a “State” section to the core package readme.
|
@geigerzaehler I'd prefer to keep the two commits instead of squashing them into one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the restructuring of the registry spec and the
corepackage we add theradicle_registry_core::statemodule and move all definitions of state entities there.This PR is split into two commits: The first removes the
registry-specpackage as it is not needed anymore. The state objects and documentation are now part ofcore::state. The errors that were part of theregistry-spechave not been migrated to a different place yet but they are outdated anyways.The second commit adds the
statemodule and the necessary documentation. We also document how to document state entities in thecoreREADME.