refactor: improve project and source browsing

[xla]

Fixes #970
Fixes #1141
Fixes #1145

[rudolfs]

Revision selector looks wonky:

revision selector	peer selector

• the expand icon should be visible in both expanded and collapsed states (like in peer selector)
• the expand icon is misaligned

[xla]

One note (not a blocker): Once I click on any file (commit is in the file) I would expect to always be able to click back on "Files" and that resets the source view, meaning that the latest commit would be back above the file. Now I can only get back there by refreshing the app.

This is implemented in 26d16bf

[rudolfs]

Revision selector ordering is mixed up, the selected branch is always shown first in the list:

master	xla/refactor-peer-selection

[xla]

the expand icon should be visible in both expanded and collapsed states (like in peer selector)

This is how master works as well, can change it. Just wanna make sure that we want all selectors work the same.

Revision selector ordering is mixed up, the selected branch is always shown first in the list:

This was suggested by @cloudhead and I agree that it makes sense with our current dropdown UX. We can review that once we make it more sophisticated: highlighting default branch, add filtering to the dropdown.

[cloudhead]

Yeah it now behaves how dropdowns are supposed to behave 👍

[cloudhead]

the expand icon should be visible in both expanded and collapsed states (like in peer selector)

This seems strange, where do you see that?

In Figma you can see that the expand button isn't there when expanded, which makes sense: https://www.figma.com/file/owmgsbs6lnUt8R1bixstCA/%F0%9F%8C%B1%F0%9F%86%99-Radicle-Upstream?node-id=4147%3A7516

[cloudhead]

This is implemented in 26d16bf

Could we preserve the behavior though when you click on it from the Commits view? So it preserves the file you were on, but if you're already on the Files view, then it goes to root? 😬

[xla]

Could we preserve the behavior though when you click on it from the Commits view? So it preserves the file you were on, but if you're already on the Files view, then it goes to root? grimacing

Done in 597cb35

[rudolfs]

This seems strange, where do you see that?

In Figma you can see that the expand button isn't there when expanded, which makes sense: https://www.figma.com/file/owmgsbs6lnUt8R1bixstCA/%F0%9F%8C%B1%F0%9F%86%99-Radicle-Upstream?node-id=4147%3A7516

@cloudhead you're right. We changed the peer selector here: #1261 (comment). Now that I look at it again, I think we should have just added a spacer that takes up as much space as the icon to avoid the "jumping", thanks for pointing out!

[rudolfs]

Awesome work! 🚀

Found just one small thing:

• Figma reference 8px:
  

• We have 12px:

Not a blocker, can also be addressed later.

[xla]

Not a blocker, can also be addressed later.

Was triggering me as well, do we have a proper rem value for it?

[rudolfs]

Was triggering me as well, do we have a proper rem value for it?

@xla 0.5rem

[MeBrei]

⭐ ⛰️ ⭐

[juliendonck]

@xla merge it! quick!

[cloudhead]

🎂