Skip to content

Conversation

@alexandrehassan
Copy link
Contributor

I don't know if this is where you want the singleton Meta class to be (or the tests). This completely removes the pysingleton library. Closes #471 .

Added quick tests to prove that it replaces the old singleton.

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.44%. Comparing base (e9d7a8b) to head (eed81d7).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
+ Coverage   87.41%   87.44%   +0.02%     
==========================================
  Files          38       38              
  Lines        2329     2334       +5     
==========================================
+ Hits         2036     2041       +5     
  Misses        293      293              
Flag Coverage Δ
unittests 87.44% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

return ret


class Singleton(type):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

location is fine a bit more comments how that works and how to use it here would be nice

@fliiiix
Copy link
Member

fliiiix commented Nov 14, 2025

Can you rebase and make sure these 2 commits are not part of this mr?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove usage of abandoned pysingleton

2 participants