Repository navigation
Refactor and extract RolloutHealthMonitor - #21
Merged
Merged
Conversation
GuanxingLu
pushed a commit
to GuanxingLu/miles
that referenced
this pull request
Apr 21, 2026
fzyzcjy
added a commit
that referenced
this pull request
Jul 8, 2026
Group the fault-tolerance work into folders instead of scattering it across miles/utils and megatron_utils: - miles/utils/ft_utils/: control_server, health_checker, heartbeat_utils, indep_dp, mini_ft_controller, process_group_utils - miles/utils/audit_utils/: event_analyzer, event_logger, witness, checksum_utils, process_identity - miles/utils/tracking_utils/: structured_log - miles/utils/test_utils/: clock, det_process_group - miles/backends/megatron_utils/ft/: checkpoint_transfer, in_memory_checkpoint, indep_dp, types The tracking facade moves from tracking_utils/__init__.py to tracking_utils/tracking.py (callers import the submodule) so that importing tracking_utils.structured_log does not run a package __init__ that circularly imports the event logger. Pure relocation: git-mv moves, empty package __init__ files, dotted import-path rewrites, and dot-depth fixes for the relative imports that cross a moved path (plus isort reordering). No code changes. Script: ft_restructure_transform.py (attached to the PR); reproduce via verify_mechanical_refactor(base, target, transform) — byte-identical. ci-sglang-pr: #28524 ci-megatron-pr: #21
fzyzcjy
added a commit
that referenced
this pull request
Jul 8, 2026
Group the fault-tolerance work into folders instead of scattering it across miles/utils and megatron_utils: - miles/utils/ft_utils/: control_server, health_checker, heartbeat_utils, indep_dp, mini_ft_controller, process_group_utils - miles/utils/audit_utils/: event_analyzer, event_logger, witness, checksum_utils, process_identity - miles/utils/tracking_utils/: structured_log - miles/utils/test_utils/: clock, det_process_group - miles/backends/megatron_utils/ft/: checkpoint_transfer, in_memory_checkpoint, indep_dp, types The tracking facade moves from tracking_utils/__init__.py to tracking_utils/tracking.py (callers import the submodule) so that importing tracking_utils.structured_log does not run a package __init__ that circularly imports the event logger. Pure relocation: git-mv moves, empty package __init__ files, dotted import-path rewrites, and dot-depth fixes for the relative imports that cross a moved path (plus isort reordering). No code changes. Script: ft_restructure_transform.py (attached to the PR); reproduce via verify_mechanical_refactor(base, target, transform) — byte-identical. ci-sglang-pr: #28524 ci-megatron-pr: #21
guapisolo
added a commit
that referenced
this pull request
Oct 3, 2026
State the router requirement once, in the supported-configurations list next to the SGLang requirement: radixark/sgl-router-for-miles #21 (df2c790) or a descendant. The previous wording pointed at the Miles Docker image, which installs router wheels from a mutable release tag; the package version stayed 0.3.2 across #21, so neither identifies a compatible build. smg --version-verbose reports the embedded commit. Drop the reference to SGLang #41373, which is unmerged and does not forward sampling_logprobs_mode, and name the failure each incompatibility produces. Remove the router notes from the recipe and data-contract sections. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.