Repository navigation
[AMD] retune AMD 4-node dsv4 config - #2139
Merged
guapisolo merged 2 commits intoAug 4, 2026
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
XinyuJiangCMU
added a commit
to XinyuJiangCMU/miles
that referenced
this pull request
Aug 4, 2026
Zhiyao's retune, applied by hand because our copy of this file has drifted: the two changes her diff makes to the response length and to mem-fraction are already in ours at the same values, so only four land. - TP8 -> TP4 for the 32-GPU config - SGLANG_HACK_FLASHMLA_BACKEND triton -> unified_kv_triton, which lives in compressor v2 only, so SGLANG_OPT_USE_COMPRESSOR_V2 goes back in alongside it - SGLANG_OPT_USE_JIT_NORM false -> true That last one reverses radixark#2040. It is taken deliberately: the logprobdiff regression that pinned it to false was in the v1 norm+rope path, and this config forces compressor v2, so the old reasoning may no longer hold. Nothing has measured it either way on v2 yet, so train_rollout_logprob_abs_diff on the next run is what decides it. Healthy is around 0.045 against a noise floor of 0.0015; the regression that produced the pin read 0.131. Co-authored-by: Zhiyao Jiang <jessicajiang324@gmail.com>
guapisolo
approved these changes
Aug 4, 2026
Contributor
|
With these changes, on 4 nodes (32x MI355X), a steady step at 8k takes ~150s for rollout and ~182s for actor training, with a full cycle time of ~7.9 min. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.