Repository navigation
[AMD] docker: build the ROCm images on the sglang v0.5.20 release images - #3873
Merged
guapisolo merged 1 commit intoSep 30, 2026
Merged
Conversation
Switch rocm724-mi35x and rocm10-mi35x from the 09-19 rocm/sgl-dev daily builds to lmsysorg/sglang:v0.5.20-rocm724-mi35x / v0.5.20-rocm10-mi35x. The 09-19 builds include sgl-project/sglang#40033, which moved build_tree_kernel_efficient and verify_tree_greedy out of the prebuilt ROCm sgl_kernel, while sglang-miles still calls them. Co-authored-by: Zhiyao Jiang <jessicajiang324@gmail.com>
guapisolo
approved these changes
Sep 30, 2026
michaelzhang-ai
added a commit
to michaelzhang-ai/miles
that referenced
this pull request
Oct 2, 2026
Use lmsysorg/sglang:v0.5.20-rocm10-mi30x, like the mi35x variants since radixark#3873. docker/rocm.Dockerfile is identical between v0.5.20 and the 09-19 main the dated base was built from (torch 2.11.0+rocm10.0.0, aiter 4ad99832), so the rocm10-gfx942-v0.5.20 wheels still match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Since #3326 moved the rocm10-mi35x base to
rocm/sgl-dev:v0.5.20-rocm10-mi35x-20260919, three EAGLE tests in the ROCm nightly (test_mimo_7B_mtp_only_grad,test_session_server_multi_role/test_qwen35,test_qwen36) have hit the 1800 s per-file timeout every night.Dated
rocm/sgl-devtags are daily builds of sglangmain. The 0919 build includes sgl-project/sglang#40033, which movedbuild_tree_kernel_efficientandverify_tree_greedyout of the prebuilt ROCmsgl_kernel. The image then installssglang-miles, which branched frommainat d58342de (09-15) and still calls these ops. The server dies at the first speculative step, and the test waits until the timeout.Modification
Switch rocm10-mi35x and rocm724-mi35x to
lmsysorg/sglang:v0.5.20-rocm10-mi35xandv0.5.20-rocm724-mi35x. These are the ROCm images of sglang v0.5.20, the same version the cu13 images use.v0.5.20tag is d58342de plus 5 cherry-picks that don't touch kernels, so the prebuilt kernels matchsglang-miles.WHEELS_TAG_ROCMis unchanged.APPLY_ROCR_VMMFIXstay.Test (MI355X)
build_tree_kernel_efficientandverify_tree_greedyare registered in the images rebuilt on both bases.test_mimo_7B_mtp_only_grad336 s,test_qwen35666 s,test_qwen36660 stest_mimo_7B_mtp_only_gradhits a GPU memory access fault while sglang starts. A rebuild on the 09-16 dated rocm724 base faults the same way, so this change doesn't cause it. rocm724 CI doesn't run these three tests.