Skip to content

[AMD] docker: build the ROCm images on the sglang v0.5.20 release images - #3873

Merged
guapisolo merged 1 commit into
radixark:mainfrom
XinyuJiangCMU:rocm-base-sglang-v0.5.20-release
Sep 30, 2026
Merged

guapisolo merged 1 commit into
radixark:mainfrom
XinyuJiangCMU:rocm-base-sglang-v0.5.20-release

Conversation

@XinyuJiangCMU

@XinyuJiangCMU XinyuJiangCMU commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

Since #3326 moved the rocm10-mi35x base to rocm/sgl-dev:v0.5.20-rocm10-mi35x-20260919, three EAGLE tests in the ROCm nightly (test_mimo_7B_mtp_only_grad, test_session_server_multi_role/test_qwen35, test_qwen36) have hit the 1800 s per-file timeout every night.

Dated rocm/sgl-dev tags are daily builds of sglang main. The 0919 build includes sgl-project/sglang#40033, which moved build_tree_kernel_efficient and verify_tree_greedy out of the prebuilt ROCm sgl_kernel. The image then installs sglang-miles, which branched from main at d58342de (09-15) and still calls these ops. The server dies at the first speculative step, and the test waits until the timeout.

Modification

Switch rocm10-mi35x and rocm724-mi35x to lmsysorg/sglang:v0.5.20-rocm10-mi35x and v0.5.20-rocm724-mi35x. These are the ROCm images of sglang v0.5.20, the same version the cu13 images use.

  • The v0.5.20 tag is d58342de plus 5 cherry-picks that don't touch kernels, so the prebuilt kernels match sglang-miles.
  • torch 2.11.0, ROCm SDK 10.0.0 and aiter 4ad99832 are the same as in the current base, so WHEELS_TAG_ROCM is unchanged.
  • For rocm724, torch 2.11.0+rocm7.2, ROCm 7.2.4 and aiter 4ad99832 are also unchanged, so its wheels and APPLY_ROCR_VMMFIX stay.

Test (MI355X)

  • build_tree_kernel_efficient and verify_tree_greedy are registered in the images rebuilt on both bases.
  • Diagnosis: rebuilt on the 09-16 dated base (before [Kernel] Move CUDA and ROCm speculative kernels to JIT sgl-project/sglang#40033), all three tests pass: 336 s / 670 s / 646 s.
  • Rebuilt on these bases (same sglang-miles / Miles / Megatron commits as the 09-29 nightly):
    • rocm10: all three pass, test_mimo_7B_mtp_only_grad 336 s, test_qwen35 666 s, test_qwen36 660 s
    • rocm724: image builds, but test_mimo_7B_mtp_only_grad hits a GPU memory access fault while sglang starts. A rebuild on the 09-16 dated rocm724 base faults the same way, so this change doesn't cause it. rocm724 CI doesn't run these three tests.

Switch rocm724-mi35x and rocm10-mi35x from the 09-19 rocm/sgl-dev daily
builds to lmsysorg/sglang:v0.5.20-rocm724-mi35x / v0.5.20-rocm10-mi35x.
The 09-19 builds include sgl-project/sglang#40033, which moved
build_tree_kernel_efficient and verify_tree_greedy out of the prebuilt
ROCm sgl_kernel, while sglang-miles still calls them.

Co-authored-by: Zhiyao Jiang <jessicajiang324@gmail.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@guapisolo
guapisolo merged commit 874b3e2 into radixark:main Sep 30, 2026
20 checks passed
michaelzhang-ai added a commit to michaelzhang-ai/miles that referenced this pull request Oct 2, 2026
Use lmsysorg/sglang:v0.5.20-rocm10-mi30x, like the mi35x variants since radixark#3873.
docker/rocm.Dockerfile is identical between v0.5.20 and the 09-19 main the
dated base was built from (torch 2.11.0+rocm10.0.0, aiter 4ad99832), so the
rocm10-gfx942-v0.5.20 wheels still match.
@XinyuJiangCMU
XinyuJiangCMU deleted the rocm-base-sglang-v0.5.20-release branch October 24, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants