Skip to content

[AMD] build(docker): bump ROCm torch_memory_saver to 118b09b - #4318

Merged
guapisolo merged 1 commit into
radixark:mainfrom
XinyuJiangCMU:pr/rocm-tms-118b09b-20261022
Oct 22, 2026
Merged

guapisolo merged 1 commit into
radixark:mainfrom
XinyuJiangCMU:pr/rocm-tms-118b09b-20261022

Conversation

@XinyuJiangCMU

Copy link
Copy Markdown
Contributor

Problem

The ROCm image pins torch_memory_saver to 06caa534. The CUDA images now pin 118b09b, which synchronizes devices before pause() backs up or unmaps memory, so the ROCm image can still back up or unmap memory while work is in flight on another stream.

Change

Pin the ROCm image to the same torch_memory_saver commit, 118b09b.

Validation

Tested on MI355X with the current ROCm 10 nightly image: 118b09b builds, its new pause-sync tests pass (10/10), and the other tests give the same results as the old pin.

Co-author-with: @JessicaJiang-123

Pin the ROCm image to the same torch_memory_saver commit as the CUDA
images, which synchronizes devices before pause() backs up or unmaps memory.

Co-authored-by: Zhiyao Jiang <jessicajiang324@gmail.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@guapisolo
guapisolo merged commit 203a8d2 into radixark:main Oct 22, 2026
23 checks passed
@XinyuJiangCMU
XinyuJiangCMU deleted the pr/rocm-tms-118b09b-20261022 branch October 24, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants