update JSON adapter pagination links how to guide

[edwinlunando]

No description provided.

[bf4]

hi @edwinlunando thanks for this. Can you explain your motivation for the new example and for removing the existing example? What version of AMS are you targeting?

[edwinlunando]

Because the current master documentation on adding pagination link is now broken. I tried the master version and following the guide, but it is not working. #1466

[bf4]

@edwinlunando would you be up to amending this PR to include a failing test for the documented scenario? That should be working.

[bf4]

Looks like the meta option was moved into the adapter in https://github.com/rails-api/active_model_serializers/pull/1233/files#diff-1bab1447950ba5f1422e5a9c8442c687L10 (CollectionSerializer is just a rename, no behavior change)

[edwinlunando]

Yes. That's why the old method on adding pagination links is not working. The current docs is misleading.

[cassiascheffer]

👍 to this or something similar. I was just stumped on the same issue.

[edwinlunando]

Any feedback on this? I believe this is quite important since the current docs is wrong.

[bf4]

Sorry for delay and thanks for following up! ❤️ I'll review soon

B mobile phone

On Feb 12, 2016, at 6:30 AM, Edwin Lunando [email protected] wrote:

Any feedback on this? I believe this is quite important since the current docs is wrong.

—
Reply to this email directly or view it on GitHub.