Skip to content

Fix warning on Thor #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2016
Merged

Fix warning on Thor #2008

merged 1 commit into from
Dec 19, 2016

Conversation

kirs
Copy link
Contributor

@kirs kirs commented Dec 19, 2016

The default argument type for Thor is string. Unless it's specified that we pass boolean, we get the warning:

Expected string default value for '--serializer'; got true (boolean)

Details: rails/thor@605897b

@bf4

The default argument type for Thor is `string`. Unless it's specified that we pass `boolean`, we get the warning:

`Expected string default value for '--serializer'; got true (boolean)`

Details: rails/thor@605897b
@mention-bot
Copy link

@kirs, thanks for your PR! By analyzing the history of the files in this pull request, we identified @todd to be a potential reviewer.

@rafaelfranca rafaelfranca merged commit 4432257 into rails-api:0-9-stable Dec 19, 2016
@kirs kirs deleted the patch-2 branch December 19, 2016 19:58
@bf4
Copy link
Member

bf4 commented Dec 20, 2016

Good to know.

@bf4 bf4 mentioned this pull request Jan 6, 2017
@algodave
Copy link

@kirs @rafaelfranca I am getting this same issue on 0.10.4 but can't understand why, as I see boolean: true here

I have gem 'rails', '~> 5.0.1' in my Gemfile and so thor (0.19.4) in my Gemfile.lock

Any idea why? Thanks!

@kirs
Copy link
Contributor Author

kirs commented Jan 10, 2017

@algodave you should update to start using the AMS version from github:

gem 'active_model_serializers', github: 'rails-api/active_model_serializers', branch: '0-9-stable'

@bf4
Copy link
Member

bf4 commented Jan 10, 2017

@kirs @algodave this happened while I was on holiday and I forgot about it. Thanks for the push, I'll release a new version. https://twitter.com/rubygems/status/818946484213313536 0.9.6

@bf4
Copy link
Member

bf4 commented Jan 10, 2017

Feel free to join the https://amserializers.herokuapp.com/ slack!! ✨

@algodave
Copy link

Thanks for the hints guys, and sorry for misunderstanding: I am using 0.10, so I fixed with:

gem 'active_model_serializers', github: 'rails-api/active_model_serializers', branch: '0-10-stable'

@algodave
Copy link

And thanks for the invite @bf4 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants