Skip to content

Fix AMS warnings #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2017
Merged

Fix AMS warnings #2019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40489fa
Fix method redefined warning
bf4 Jan 6, 2017
ced317d
Fix thor warning to set type: :boolean, was setting `{ banner: "" }`
bf4 Jan 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/generators/rails/resource_override.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
module Rails
module Generators
class ResourceGenerator
hook_for :serializer, default: true, boolean: true
hook_for :serializer, default: true, type: :boolean
end
end
end
1 change: 1 addition & 0 deletions test/generators/serializer_generator_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ def stub_safe_constantize(expected:)
yield
ensure
String.class_eval do
undef_method :safe_constantize
alias_method :safe_constantize, :old
undef_method :old
end
Expand Down