Support XML and JSON inflector acronyms #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
acronym-support
branch
2 times, most recently
from
9122780 to
c65cc65
Compare
Member
|
Instead of adding aliases, I think we should just stop using the inflector |
Related to rails#361 Add special-case treatment of JSON and XML acronyms by making direct references to the `JsonFormat` and `XmlFormat` constants, rather than relying on inflections. The original PR included a comment citing that `ActiveSupport::Inflector::Inflections#clear` was not working as expected. It was resolved by [a76344f][], which was merged into `main` prior to the `7.0.0` release. Since the CI matrix currently includes `7-0-stable` as the minimum version, the code can rely on the resolved behavior. [a76344f]: rails/rails@a76344f
seanpdoyle
force-pushed
the
acronym-support
branch
from
c65cc65 to
a90bf24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #361
Add special-case treatment of JSON and XML acronyms by declaring aliases for the
JsonFormatandXmlFormatconstants.In addition to the aliases, this commit also includes test coverage to cover existing behavior.
The original PR included a comment citing that
ActiveSupport::Inflector::Inflections#clearwas not working as expected. It was resolved by a76344f, which was merged intomainprior to the7.0.0release. Since the CI matrix currently includes7-0-stableas the minimum version, the code can rely on the resolved behavior.