Skip to content

Optimize _key to prevent string allocation when formatting Symbols #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimize _key to prevent string allocation when formatting Symbols #593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/jbuilder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,13 @@ def _merge_values(current_value, updates)
end

def _key(key)
@key_formatter ? @key_formatter.format(key) : key.to_s
if @key_formatter
@key_formatter.format(key)
elsif key.is_a?(::Symbol)
key.name
else
key.to_s
end
end

def _format_keys(hash_or_array)
Expand Down