Optimize internal extract!
calls to save on memory allocation
#598
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply optimizes internal calls to
extract!
to avoid extra memory allocations to splat the*attributes
. Both_extract_hash_values
and_extract_method_values
accept an array forattributes
, so no need to re-splat it by callingextract!
, which then splats it again.Solution is to implement a private
_extract
that just accepts an array, which can be used internally.A simple way to compare it is with the
call
DSL, which was just runningextract!
underneath.This change has no impact in using
json.extract!
directly.