Skip to content

Fix broken Nokogiri documentation links in README.md #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mikeygough
Copy link

@mikeygough mikeygough commented Jun 7, 2025

Howdy,

I noticed two broken links in this gem's README.md.

This PR updates those broken links ( for Nokogiri::XML::Node & Nokogiri::XML::NodeSet ). They should now point to the correct pages on RubyDoc.info.

Alternatively, we could use the Nokogiri documentation page instead of RubyDoc.info. Those links would be

Cheers,
Mikey

Copy link
Member

@flavorjones flavorjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikeygough Thanks. I would prefer if we used the official Nokogiri docs (which I maintain, in addition to this gem).

Apologies for the slow review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants