Make dev server binstub optional #1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javan
reviewed
Nov 18, 2017
| @@ -53,7 +53,7 @@ def record_compilation_digest | |||
| def run_webpack | |||
| logger.info "Compiling…" | |||
|
|
|||
| sterr, stdout, status = Open3.capture3(webpack_env, "#{RbConfig.ruby} ./bin/webpack") | |||
| sterr, stdout, status = Open3.capture3(webpack_env, "bundle exec webpack") | |||
There was a problem hiding this comment.
./bin/* binstubs aren't really needed when using bundle exec, right? If so, the check_binstubs name isn't really accurate. We only care that webpacker the gem is installed.
There was a problem hiding this comment.
Yeah, I guess the whole./bin thing is now irrelevant. Will clean this up in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #988 and #992
Since we now have proper binstubs.