Skip to content

Async photo & stitching #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 29, 2024
Merged

Conversation

abdelaziz-mahdy
Copy link
Contributor

@abdelaziz-mahdy abdelaziz-mahdy commented Jun 28, 2024

fix #123

Async Photo

  • C wrappers
  • dart bindings
  • tests

Async Stitching

  • C wrappers
  • dart bindings
  • tests

@abdelaziz-mahdy abdelaziz-mahdy marked this pull request as draft June 28, 2024 12:22
@abdelaziz-mahdy
Copy link
Contributor Author

question related to the photo_async.dart

should the dst be created in c++ or what i am doing is the correct way?

@rainyl
Copy link
Owner

rainyl commented Jun 28, 2024

question related to the photo_async.dart

should the dst be created in c++ or what i am doing is the correct way?

Create it in c++, if created here, the creation itself is currently synchronous, although creating an empty Mat is fast, it's still not recommended.

@rainyl rainyl linked an issue Jun 28, 2024 that may be closed by this pull request
6 tasks
@abdelaziz-mahdy
Copy link
Contributor Author

question related to the photo_async.dart

should the dst be created in c++ or what i am doing is the correct way?

Create it in c++, if created here, the creation itself is currently synchronous, although creating an empty Mat is fast, it's still not recommended.

Ok will do so, and return it's pointer. Then will check stitching

@abdelaziz-mahdy abdelaziz-mahdy marked this pull request as ready for review June 29, 2024 08:37
@rainyl rainyl merged commit feeb89a into rainyl:async Jun 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async Photo & Stitching
2 participants