Skip to content

Upgrade library and plugin versions #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Conversation

jeffmay
Copy link
Contributor

@jeffmay jeffmay commented Dec 13, 2020

  • Upgrade build configs to use latest versions and new sbt plugins
    • Set root scalaVersion to 2.13.5
    • Use sbt-dynver and sbt-mima plugins
    • Remove sbt-git-versioning
    • Remove unused resolvers
    • Upgrade to sbt 1.5.0
    • Upgrade Scala versions
    • Add documentation about why use Scala 2.12.12 instead of 2.12.13
    • Upgrade ScalaTest to 3.2.7
    • Upgrade to latest Play versions
    • Update .travis.yml build configs to test for binary compatibility with sbt-mima plugin
  • Fix deprecation warnings, remove unnecessary implicits, and fix tests
    • Use GuiceApplicationBuilder instead of default ApplicationBuilder
    • Avoid use of deprecated Play methods
    • Use global execution context to avoid deadlock in scalatest

@jeffmay jeffmay force-pushed the jeff/upgrade-infrastructure branch 2 times, most recently from 0a17464 to 215bfdf Compare December 14, 2020 06:07
Copy link

@paul-a-kennedy-rally paul-a-kennedy-rally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paul-a-kennedy-rally
Copy link

retest this please

@jeffmay jeffmay force-pushed the jeff/upgrade-infrastructure branch from 215bfdf to 936d177 Compare April 14, 2021 01:42
@jeffmay
Copy link
Contributor Author

jeffmay commented Apr 14, 2021

I removed the dependency on sbt-git-versioning in favor of sbt-dynver and sbt-mima plugins. The process for releasing is a little more convoluted, but it should hold until I fix the sbt-git-versioning plugin to only make mima easier to work with (removing the git versioning stuff provided by sbt-dynver)

@jeffmay
Copy link
Contributor Author

jeffmay commented Apr 14, 2021

Looks like I can't update to Scala 2.12.13 because of scoverage/sbt-scoverage#321. I'm looking for an appropriate version of Scala 2.12 that I can use.

@jeffmay jeffmay force-pushed the jeff/upgrade-infrastructure branch from 281c306 to 1749e56 Compare April 14, 2021 02:09
jeffmay added 2 commits April 14, 2021 09:27
- Set root scalaVersion to 2.13.5
- Use sbt-dynver and sbt-mima plugins
- Remove sbt-git-versioning
- Remove unused resolvers
- Upgrade to sbt 1.5.0
- Upgrade Scala versions
- Add documentation about why use Scala 2.12.12 instead of 2.12.13
- Upgrade ScalaTest to 3.2.7
- Upgrade to latest Play versions
- Update .travis.yml build configs to test for binary compatibility with
  sbt-mima plugin
- Use GuiceApplicationBuilder instead of default ApplicationBuilder
- Avoid use of deprecated Play methods
- Use global execution context to avoid deadlock in scalatest
@jeffmay jeffmay force-pushed the jeff/upgrade-infrastructure branch from 1749e56 to dcb718d Compare April 14, 2021 16:27
@jeffmay jeffmay merged commit 9f5e645 into master Apr 14, 2021
@jeffmay jeffmay deleted the jeff/upgrade-infrastructure branch April 14, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants