Skip to content

WaiMultiSession#1

Open
ramirez7 wants to merge 2 commits intomasterfrom
feature/WaiMultiSession
Open

WaiMultiSession#1
ramirez7 wants to merge 2 commits intomasterfrom
feature/WaiMultiSession

Conversation

@ramirez7
Copy link
Owner

@ramirez7 ramirez7 commented Jun 28, 2017

Like WaiSession but with as many Applications as you want :)

Useful for integration tests between distinct services, but in the lightweight hspec-wai style.

Summary

  • Added WaiMultiSession, which is a Reader of a list of type-tagged Applications
  • Refactored Test.Hspec.Wai.Servant.Assertions to work for WaiSession or WaiMultiSession
  • Added a test that has 3 services that call each other in a non-trivial way to exercise WaiMultiSession. I'm happy with it!

Testing Done

  • nix-build succeeds w/tests passing
  • I browsed the haddocks locally to make sure they seem useful

Like WaiSession but with as many Applications as you want :)

Useful for integration tests between distinct services, but in the
lightweight hspec-wai style.
@ramirez7 ramirez7 force-pushed the feature/WaiMultiSession branch from 6b0459c to 6f6238f Compare June 28, 2017 18:59
@schell
Copy link
Collaborator

schell commented May 8, 2018

Are there any blockers on this? I have a use case in mind.

@ramirez7
Copy link
Owner Author

ramirez7 commented May 9, 2018

@schell Aside from the merge conflicts and potential bugs/type errors that result from those, I think this is still good to go? If you have a use-case, I'd love to fix it up and merge it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants