Skip to content

add dropdown menu to change rows count in events table in cluster dashboard #14622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aalves08
Copy link
Member

Summary

Fixes #12049

Occurred changes and/or fixed issues

  • add dropdown menu to change rows count in events table in cluster dashboard
  • e2e test
Screenshot 2025-06-27 at 14 48 06

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility

@aalves08 aalves08 added this to the v2.12.0 milestone Jun 27, 2025
@aalves08 aalves08 requested a review from nwmac June 27, 2025 13:52
@aalves08 aalves08 self-assigned this Jun 27, 2025
@richard-cox richard-cox self-requested a review June 27, 2025 15:42
@@ -103,7 +160,7 @@ export default {
:table-actions="false"
:row-actions="false"
:groupable="false"
:rows-per-page="10"
:rows-per-page="rowsPerPage"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does changing this when vai is on result in a new http request?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have not checked

@nwmac
Copy link
Member

nwmac commented Jul 2, 2025

@richard-cox Made some tweaks for your review

@richard-cox richard-cox self-requested a review July 3, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cluster dashboard events list always shows 10 items, not the number configured in preferences
3 participants