fix the logic for getting pod IP #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakefhyde
reviewed
Nov 3, 2025
pedromfcarvalho
approved these changes
Nov 4, 2025
jakefhyde
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
rancher/rancher#52155
Problem
This bug was identified while debugging the provisioning test.
The Pod node driver assigns the IP address from the first pod in the namespace rather than the intended target pod. Consequently, if the RKE2 server is configured using the value from rancher-machine, the node’s public IPv4 address is set incorrectly, causing the node to remain stuck in the “activating” state.
The logic can be found at https://github.com/rancher/machine/blob/master/drivers/pod/pod.go#L270-L284
Solution
Teseting
The image built from this branch is used to run the
Test_Provisioning_MP_MultipleEtcdNodesScaledDownThenDeletetest in rancher/rancher. The test passes successfully, and as shown in the screenshot below, the image used by the machine-provisioning pod is from the customized image, and the logging messages now provide more detailed information.