Skip to content

Specify each verb instead of using * in project owner#55061

Merged
JonCrowther merged 2 commits into
rancher:mainfrom
JonCrowther:improve-role-specificity
May 13, 2026
Merged

Specify each verb instead of using * in project owner#55061
JonCrowther merged 2 commits into
rancher:mainfrom
JonCrowther:improve-role-specificity

Conversation

@JonCrowther

Copy link
Copy Markdown
Contributor

Issue:

Problem

To conform to RBAC best practices, change * permissions in project-owner to be an explicit list of verbs

Solution

Testing

Engineering Testing

Manual Testing

Automated Testing

  • Test types added/modified:
    • Unit
    • Integration (Go Framework)
    • Integration (v2prov Framework)
    • Validation (Go Framework)
    • Other - Explain: EXPLAIN
    • None
    • REMOVE NOT APPLICABLE BULLET POINTS ABOVE
  • If "None" - Reason: EXPLAIN THE REASON
  • If "None" - GH Issue/PR: LINK TO GH ISSUE/PR TO ADD TESTS

Summary: TODO

QA Testing Considerations

Regressions Considerations

TODO

Existing / newly added automated tests that provide evidence there are no regressions:

  • TODO

@github-actions

Copy link
Copy Markdown
Contributor

Provisioning Tests Results

  7 files   42 suites   3h 49m 47s ⏱️
 71 tests  71 ✅ 0 💤 0 ❌
141 runs  133 ✅ 8 💤 0 ❌

Results for commit d33cd93.

@JonCrowther
JonCrowther merged commit 2800aaa into rancher:main May 13, 2026
22 checks passed
@JonCrowther
JonCrowther deleted the improve-role-specificity branch May 13, 2026 18:25
JonCrowther added a commit that referenced this pull request May 14, 2026
* Specify each verb instead of using *

* Fix test
JonCrowther added a commit that referenced this pull request May 14, 2026
* Specify each verb instead of using *

* Fix test
JonCrowther added a commit that referenced this pull request May 14, 2026
* Specify each verb instead of using *

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants