Skip to content

Add cudf::strings::split_part API #19289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 17, 2025

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Jul 3, 2025

Description

Adds new strings API

std::unique_ptr<column> split_part(
  strings_column_view const& input,
  string_scalar const& delimiter,
  size_type index,
  rmm::cuda_stream_view stream,
  rmm::device_async_resource_ref mr);

This will perform a split on each row using the given delimiter but only return the token at 0-based index.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt self-assigned this Jul 3, 2025
@davidwendt davidwendt added feature request New feature or request 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Jul 3, 2025
Copy link

copy-pr-bot bot commented Jul 3, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added the CMake CMake build issue label Jul 3, 2025
@davidwendt
Copy link
Contributor Author

/ok to test

@davidwendt
Copy link
Contributor Author

/ok to test

@davidwendt
Copy link
Contributor Author

/ok to test

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jul 8, 2025
@davidwendt davidwendt marked this pull request as ready for review July 8, 2025 18:03
@davidwendt davidwendt requested review from a team as code owners July 8, 2025 18:03
@davidwendt davidwendt requested review from devavret and vuule July 8, 2025 18:03
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question otherwise LGTM

@GregoryKimball GregoryKimball moved this to Burndown in libcudf Jul 11, 2025
@davidwendt davidwendt requested a review from vuule July 15, 2025 23:44
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake approval. (Skimmed C++, also seems fine.)

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit e16037a into rapidsai:branch-25.08 Jul 17, 2025
91 checks passed
@davidwendt davidwendt deleted the strings-split-part branch July 17, 2025 21:24
@mhaseeb123 mhaseeb123 moved this from Burndown to Landed in libcudf Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
Status: Landed
Development

Successfully merging this pull request may close these issues.

4 participants